[Webkit-unassigned] [Bug 243979] New: EWS failed to apply a patch correctly when it had committer date in the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 00:30:41 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=243979

            Bug ID: 243979
           Summary: EWS failed to apply a patch correctly when it had
                    committer date in the patch
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kkinnunen at apple.com

EWS failed to apply a patch correctly when it had committer date in the patch

1. I created a patch and a PR around Aug 12, uploaded with `git webkit pr --no-update`
2. I rebased, amended the commit on Aug 15. It was now on top of Aug 15 ToT.
3. I uploaded the new patch with `git webkit pr --no-update`, on Aug 15.
4. I set the merge-queue

EWS tried to rebase the patch on top of Aug 15 ToT with a upstream commit of Aug 11.
(git rebase --onto <newbase> <upstream> <branch>)

Naturally this rebase fails, at it tries to re-apply commits between Aug 11-15 on top of Aug 15 ToT. 

https://ews-build.webkit.org/#/builders/69/builds/29926/steps/10/logs/stdio

git rebase --onto 7654da12692d947efe23243092725dc6abc96436 6bb3f1342f342358061b525c7b8f077b7b5ed15b eng/machsendright-to-ipc

eng/machsendright-to-ipc is correctly on Aug 15 ToT: 7654da12692d

18021d1c87d2 (HEAD -> eng/machsendright-to-ipc, fork/eng/machsendright-to-ipc) Darwin specific IPC encoding primitives are implemented in WebKit/Shared but used in WebKit/Platform/IPC https://bugs.webkit.org/show_bug.cgi?id=243870 Include a Radar link (OOPS!).
7654da12692d (origin/main, origin/HEAD, main) Navigator.share() rejects with wrong exception when called multiple times https://bugs.webkit.org/show_bug.cgi?id=243652



The <upstream> was Aug 11:
6bb3f1342f34 [GTK] Fix build on macOS https://bugs.webkit.org/show_bug.cgi?id=243759


Most likely same cause as bug 243277

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220816/839dd2ed/attachment-0001.htm>


More information about the webkit-unassigned mailing list