[Webkit-unassigned] [Bug 116073] Fix wrong assertions in Range::textNodeSplit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 15 16:08:59 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=116073

Ahmad Saleem <zlip.792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zlip.792 at gmail.com

--- Comment #1 from Ahmad Saleem <zlip.792 at gmail.com> ---
I took the test case from Chromium patch and changed it into JSFiddle:

Link - https://jsfiddle.net/foea2v5g/show

*** Safari Technology Preview 151 ***

No assertion failures even if an DOM mutation event handler updates the new node created by Text::splitText.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


FAIL r.endContainer should be [object Text]. Was [object HTMLDivElement].
FAIL r.endOffset should be 2. Was 1.
PASS successfullyParsed is true

TEST COMPLETE

*** Firefox Nightly 105 ***

No assertion failures even if an DOM mutation event handler updates the new node created by Text::splitText.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
FAIL r.endContainer should be [object Text]. Was [object HTMLDivElement].
FAIL r.endOffset should be 2. Was 1.
PASS successfullyParsed is true

TEST COMPLETE

*** Chrome Canary 106 ***

No assertion failures even if an DOM mutation event handler updates the new node created by Text::splitText.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


FAIL r.endContainer should be [object Text]. Was [object HTMLDivElement].
FAIL r.endOffset should be 2. Was 1.
PASS successfullyParsed is true

TEST COMPLETE

_________

I can find "nextSibling", which Chrome patch removed in Webkit Github source bit differently:

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/Range.cpp#L997

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/Range.cpp#L979

rniwa at webkit.org - Is this need anymore? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220815/e9310d82/attachment-0001.htm>


More information about the webkit-unassigned mailing list