[Webkit-unassigned] [Bug 243741] New: [Filters] Move the static calculateOutsets functions to the FilterOperation classes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 9 11:54:22 PDT 2022
https://bugs.webkit.org/show_bug.cgi?id=243741
Bug ID: 243741
Summary: [Filters] Move the static calculateOutsets functions
to the FilterOperation classes
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Layout and Rendering
Assignee: webkit-unassigned at lists.webkit.org
Reporter: sabouhallawa at apple.com
CC: bfulgham at webkit.org, simon.fraser at apple.com,
zalan at apple.com
The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static calculateOutsets functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call calculateReferenceFilterOutsets() from CSSFilter::calculateOutsets() as a special case.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220809/203e6534/attachment.htm>
More information about the webkit-unassigned
mailing list