[Webkit-unassigned] [Bug 232934] Fix build without opengl-or-es

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 9 06:05:24 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=232934

--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Don Olmstead from comment #3)
> I don't think this is the right fix. These files shouldn't be included at
> all if coordinated graphics isnt enabled.

This is slightly annoying to do, because you can't add conditionals to Sources.txt to control what gets compiled. It's easier to guard the entire files with #if USE(COORDINATED_GRAPHICS). But of course we don't want USE(COORDINATED_GRAPHICS) guards in the middle of a file with CoordinatedGraphics in its name.

Does USE(COORDINATED_GRAPHICS) depends on OpenGL? If so, we need to talk to Carlos Garcia about either reverting the change from bug #195094 or, more likely, removing the public build option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220809/b31505f4/attachment.htm>


More information about the webkit-unassigned mailing list