[Webkit-unassigned] [Bug 243659] New: [GTK][WPE] Expose notifications without a page in public API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 8 02:22:39 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=243659

            Bug ID: 243659
           Summary: [GTK][WPE] Expose notifications without a page in
                    public API
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: bugs-noreply at webkitgtk.org

Current notifications API is a signal emitted by WebKitWebView, but service worker notifications don't have a page associated. They don't even belong to a web process pool, there's a global notification manager for service workers. Some options that came to my mind:

 1) Deprecate current web view signal and add a global WebKitNotificationManager that emits the signal and provides the web view as an optional parameter (it could also be a property of the notification, but we would need to keep a ref of the web view in every notification).
 2) Keep current API and add a global notification manager only for service worker notifications.

I think it's probably better to add the global singleton to handle all notifications with the web view passed as a parameter. Note that Notification.requestPermission is always handled by the web process pool notification manager, so current api in web context is not affected and should still work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220808/47ca7122/attachment.htm>


More information about the webkit-unassigned mailing list