[Webkit-unassigned] [Bug 243204] ImageDocument should support dark mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=243204

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 461339
  --> https://bugs.webkit.org/attachment.cgi?id=461339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461339&action=review

Thanks, I think this is a good idea.

> LayoutTests/fast/loader/image-document-dark-mode.html:5
> +<iframe src="resources/image at test.png">

Can we instead construct a test that uses a dark mode document with an image element in it in the expected.html? The reason I suggest this is that an expected.html test is even more useful than a mismatch.html for catching future mistakes. And also, a test structured in that way could probably be turned on everywhere; it would automatically do the right thing on platforms with no dark mode support. The only tricky thing about such a test might be matching the layout that you’d get with an iframe that directly references an image, but I think that’s something likely to stay stable for a long time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220801/68a052cb/attachment.htm>