[Webkit-unassigned] [Bug 243321] [css-aspect-ratio] The transferred min/max sizes should be constrained by defined sizes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=243321

--- Comment #8 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 461335
  --> https://bugs.webkit.org/attachment.cgi?id=461335
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461335&action=review

>> LayoutTests/TestExpectations:-4602
>> -webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-045.html [ ImageOnlyFailure ]
> 
> Possibly it fixes select-element-001.html (on Mac).

Yes, removed.

>> Source/WebCore/rendering/RenderBox.cpp:679
>> +        return;
> 
> Should this be an ASSERT too?

Done

>> Source/WebCore/rendering/RenderBox.cpp:693
>> +    auto shouldCheckTransferredSizes = [&](const Length& dependedLength, const Length& determinedLength) {
> 
> dependend*

Done, thanks

>> Source/WebCore/rendering/RenderBox.h:726
>> +    enum class ConstrainWidthOrHeight { Width, Height };
> 
> This seems a bit superfluous. Something like ConstrainDimension { Width, Height }; ?

Done, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220801/d7f7e67c/attachment.htm>