[Webkit-unassigned] [Bug 243321] [css-aspect-ratio] The transferred min/max sizes should be constrained by defined sizes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=243321

--- Comment #3 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 461283
  --> https://bugs.webkit.org/attachment.cgi?id=461283
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461283&action=review

> Source/WebCore/rendering/RenderBox.cpp:5557
>  std::pair<LayoutUnit, LayoutUnit> RenderBox::computeMinMaxLogicalWidthFromAspectRatio() const

I think this can be merged with computeMinMaxLogicalHeightFromAspectRatio.

> Source/WebCore/rendering/RenderBox.cpp:5559
> +    if (!style().hasAspectRatio())

Can this happen? Should it be an ASSERT?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220801/4605d194/attachment.htm>