[Webkit-unassigned] [Bug 239387] [GStreamer] REGRESSION(r285586): we never end the playback of some videos

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=239387

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com

--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 457703
  --> https://bugs.webkit.org/attachment.cgi?id=457703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457703&action=review

> Source/WebCore/ChangeLog:3
> +        [GStreamer] REGRESSION(r285586): we never end the playback of some videos

That seems bad :( I wonder how this wasn't detected earlier with layout tests

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1787
> +            GRefPtr<GstPad> SinkPad = adoptGRef(gst_element_get_static_pad(m_videoSink.get(), "sink"));

auto sinkPad = ...

local variables should not begin with a capital letter

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1792
> +            GRefPtr<GstPad> SinkPad = adoptGRef(gst_element_get_static_pad(m_audioSink.get(), "sink"));

ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220415/22929189/attachment-0001.htm>