[Webkit-unassigned] [Bug 239328] Do not require writing commit message

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 03:06:32 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=239328

--- Comment #1 from Yusuke Suzuki <ysuzuki at apple.com> ---
I have two ideas.

1.
If we keep ChangeLogs, then I think `git webkit pr` should create PR-specific branch and generate commit messages from ChangeLogs automatically, so PR is always one commit, and we do not need to reflect our local branch's way (how many commits the local branch has etc.), and we can avoid writing the same ChangeLogs twice.

2.
If we drop ChangeLogs soon, then I suggest adding COMMIT_MESSAGE file instead. It will not be landed in the tree. And locally, we can commit in our local development branch. And git webkit generates this file automatically as we do for ChangeLogs.
We modify it for messages. git-webkit pr creates separate PR branch, which uses COMMIT_MESSAGE as a commit message and PR's issue message. But that branch also includes COMMIT_MESSAGE as a change. So reviewer can comment on commit log messages.
And when merge-queue / git-webkit lands the change, it remove COMMIT_MESSAGE from the change, and use that content as a commit message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220414/5f865bc6/attachment-0001.htm>


More information about the webkit-unassigned mailing list