[Webkit-unassigned] [Bug 239126] New: Reconsider branch naming conventions for pull requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=239126

            Bug ID: 239126
           Summary: Reconsider branch naming conventions for pull requests
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
            Blocks: 239082

The current rules from https://github.com/WebKit/WebKit/wiki/Pull-Requests say: "We suggest that pull request branch names are prefixed by eng/ or dev/ so that contributors are clear which branches contain production code when they add other user's forks as remotes." Well that works, sure: it's an easy rule, and WebKit contributors will learn to follow it quickly. But it's unclear what the benefit of this rule really is. dev/ and eng/ are not conventional: at least I've never seen them before ever, despite having used GitHub for 10 years. Normally I name my branches mcatanzaro/ to indicate they are personal dev branches and avoid clashing with others, but since WebKit requires that pull requests be submitted from forks, even that convention hardly matters for WebKit. It's unclear why there are any rules for branch naming at all. Since we disallow merge commits, the branch name should never be visible except to people who are using my personal fork as a remote.

"""
Notably, EWS is unable to apply changes which come from the branch they are targeting (ie, EWS cannot apply a change from Contributor/WebKit:main onto WebKit/WebKit:main), so in order to be reviewed, changes must come from a different branch.
"""

It seems like a strange and artificial limitation, but seems fine to restrict a source branch from being named "main" I suppose.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=239082
[Bug 239082] GitHub feedback umbrella
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220412/19f4cbf8/attachment.htm>