[Webkit-unassigned] [Bug 239036] WebKit-GTK 2.36.0 fails to build with Webassembly/JIT disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=239036

dave at killthe.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from dave at killthe.net ---
OK--after much head banging against the wall, I got this figured out. 

First off, all those link errors were due to my faulty/incomplete patch, which was an attempt to fix various compile errors when disabling WebAssembly. I didn't know in the beginning that just setting WEBKIT_ENABLE_WEBASSEMBLY=OFF isn't enough to properly disable it. After patching /Source/cmake/WebKitFeatures.cmake as described above to set the 5-6 different flags the same as the 32-bit build, and removing the faulty patch, that successfully builds WebKit with JIT disabled.

But it turns out I didn't even have to do that at all. How's this for a kick in the nuts: 

Turns out my two browsers were both linking to webkit2gtk-4.0, not -4.1. This change of course came about when libsoup3 was introduced. So this whole time I've been linking to and using the old webkit 2.32.x, even when I thought I'd long since upgraded to 2.34.x, and then to 2.36.x; and also explaining why the Debug build wouldn't give a usable backtrace.

With JIT fully enabled and just the "Debug build fix" and "accessibility disabled" patches applied, WebKit 2.36.0 builds and works just fine on the web site where 2.32.0 was crashing. So whatever the JIT bug was in 2.32.x, it's already been patched out. Meanwhile I've been unknowingly stuck on an old WebKit version, and presumably would have continued to be stuck there for a few more upgrade cycles until finally discovering the API change...and probably wondering the whole time why the hell none of these supposed fixes and upgrades in each version were taking effect.

SMH...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220410/e0283d75/attachment.htm>