[Webkit-unassigned] [Bug 221260] [JSC] Enable WasmLLInt on ARMv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221260

--- Comment #10 from Geza Lore <glore at igalia.com> ---
Comment on attachment 456911
  --> https://bugs.webkit.org/attachment.cgi?id=456911
v4

View in context: https://bugs.webkit.org/attachment.cgi?id=456911&action=review

Fixed all bar compiling out the Signaling enum value. Let me know if you prefer I changed that too.

>> Source/JavaScriptCore/interpreter/CalleeBits.h:47
>> +        , m_tag { static_cast<uint32_t>(value >> (TagOffset * CHAR_BIT)) }
> 
> why not just decode the value and grab payload and tag?

Not sure how that happened, but indeed can do that, so I did.

>> Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp:171
>> +#if ENABLE(WEBASSEMBLY_SIGNALING_MEMORY)
> 
> Do we really need to compile out this enum value?
> 
> Maybe we can achieve the same perf by adding some helpers that take in a mode and check if it's signaling vs bounds checking, and when !WEBASSEMBLY_SIGNALING_MEMORY, we can always return true from "isBoundsChecking"

The purpose of compiling this out wasn't so much performance, but getting the compiler to tell me where I need to fix things up, I found it quite difficult without. Now that it's done we can add this back in, though could catch issues in future changes, I'm happy either way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220408/c6bbec36/attachment.htm>