[Webkit-unassigned] [Bug 238947] New: Web Inspector: Don't send node payloads to the frontend for already-bound nodes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 10:50:24 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=238947

            Bug ID: 238947
           Summary: Web Inspector: Don't send node payloads to the
                    frontend for already-bound nodes
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pangle at apple.com
                CC: inspector-bugzilla-changes at group.apple.com,
                    webkit-bug-importer at group.apple.com
        Depends on: 189687

`DOM.setChildNodes`, `DOM.childNodeInserted`, `DOM.shadowRootPushed`, and `DOM.pseudoElementAdded` should all be able to provide a DOM.NodeId instead of a DOM.Node to the frontend in order to be less wasteful over the protocol. This will probably require adding a new protocol command to do the initial push of a node to the frontend, followed by one of the existing protocol commands to place the node in the DOM Tree in the correct place. As of bug 189687 we will actually go ahead an check if the node payload's ID matches an already-known node to prevent ourselves from creating a new identical frontend `WI.DOMNode` to replace the existing frontend `WI.DOMNode` if it already exists.

It's also worth noting that `DOM.childNodeInserted`, `DOM.shadowRootPushed`, and `DOM.pseudoElementAdded` could all be unified into a single event because the node itself should contain enough information to know if it is a shadow root, a pseudo-element, or an otherwise normal node.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=189687
[Bug 189687] Web Inspector: preserve DOM.NodeId if a node is removed and re-added
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220407/1cf41f02/attachment.htm>


More information about the webkit-unassigned mailing list