[Webkit-unassigned] [Bug 238871] Multiple uses of ThreadSafeRefCounted and CanMakeWeakPtr with non-thread-safe WeakPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238871

--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
(In reply to Kimmo Kinnunen from comment #6)
> (In reply to Chris Dumez from comment #3)
> > I think it would be nice if those bug reports pointed to actual bugs in our
> > code rather than theoretical issues.
> 
> Feel free to close if you think it is not a relevant bug.

I don't know yet if it relevant yet or not (and I wouldn't WONTFIX another engineers bug). I don't have a clear example yet in our code base of something that it is wrong.

Right now, this bug seems to point out that we may be doing something that is not thread safe. I am willing to believe (thread safety bugs are common in WebKit and not always easy to reason about). I just think it would be better to speak about concrete examples in our code bases of something that is wrong. Then we can focus on fixing those.

While using WeakPtr and multiple threads (which is communicated by the fact that ThreadSafeRefCounted is used), it is definitely easy to write unsafe code. It doesn't mean that all those usages in our code base are currently wrong (if that makes sense).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220406/a1d429b0/attachment.htm>