[Webkit-unassigned] [Bug 238143] [JSC][ARMv7] Support proper near calls and JUMP_ISLANDS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238143

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #455907|review?                     |review+
              Flags|                            |

--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 455907
  --> https://bugs.webkit.org/attachment.cgi?id=455907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455907&action=review

r=me with comments

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:101
> +#elif CPU(ARM)

Use CPU(ARM_THUMB2)

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:117
> +#elif CPU(ARM)

Use CPU(ARM_THUMB2)

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:455
> +            m_numAllocators = (reservation.size + m_regionSize - 1) / m_regionSize;

m_numAllocators member is not necessary since m_allocators.size() can return the same value.

> Source/WTF/wtf/FixedVector.h:103
> +    FixedVector(std::unique_ptr<Storage> storage)

Let's take it std::unique_ptr<Storage>&&.

> Source/WTF/wtf/Vector.h:105
> +            new(NotNull, cur) T(args...);

Add space after `new`

new (NotNull, cur) T(args...);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220406/b6ed661b/attachment.htm>