[Webkit-unassigned] [Bug 237282] Haiku port upstreaming: Webkitpy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237282

--- Comment #10 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 454528
  --> https://bugs.webkit.org/attachment.cgi?id=454528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454528&action=review

> Tools/Scripts/webkitpy/common/version_name_map.py:79
> +            'haiku': {'': Version(1.4)},

Should be: `Version(1, 4)`

> Tools/Scripts/webkitpy/port/haiku.py:47
> +        self._version = "1.4"

Looking through our webkitpy code, it looks to me like the ApplePort doesn't use this variable, do things work without it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220405/dd7bca9c/attachment.htm>