[Webkit-unassigned] [Bug 238790] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238790

--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
(In reply to Alexey Proskuryakov from comment #1)
> ---
> /Volumes/Data/worker/ios-simulator-15-release-gpuprocess-arm64-tests-wk2/
> build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-
> api/the-biquadfilternode-interface/no-dezippering-expected.txt
> +++
> /Volumes/Data/worker/ios-simulator-15-release-gpuprocess-arm64-tests-wk2/
> build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-
> api/the-biquadfilternode-interface/no-dezippering-actual.txt
> @@ -36,9 +36,20 @@
>  PASS   Output from gain setter matches setValueAtTime output is true.
>  PASS < [Test 3] All assertions passed. (total 5 assertions)
>  PASS > [Test 4] No dezippering of frequency vs JS filter
> -PASS   Output from lowpass filter equals [expected array] with an
> element-wise tolerance of
> {"absoluteThreshold":5.9607e-7,"relativeThreshold":0}.
> -PASS   Output matches JS filter results is true.
> -PASS < [Test 4] All assertions passed. (total 2 assertions)
> +FAIL X Output from lowpass filter does not equal [expected array] with an
> element-wise tolerance of
> {"absoluteThreshold":5.9607e-7,"relativeThreshold":0}.
> +	Index	Actual			Expected		AbsError		RelError		Test threshold
> +	[82]	-5.640129e-1	-5.640122e-1	6.556511e-7	1.162477e-6	5.960700e-7
> +	[83]	-4.615946e-1	-4.615939e-1	6.854534e-7	1.484971e-6	5.960700e-7
> +	[84]	-3.461582e-1	-3.461576e-1	6.854534e-7	1.980178e-6	5.960700e-7
> +	[85]	-2.209939e-1	-2.209932e-1	6.705523e-7	3.034267e-6	5.960700e-7
> +	[86]	-8.966466e-2	-8.966400e-2	6.556511e-7	7.312311e-6	5.960700e-7
> +	...and 1 more errors.
> +	Max AbsError of 6.854534e-7 at index of 83.
> +	Max RelError of 1.419336e-5 at index of 87.
> +	[87]	4.409384e-2	4.409447e-2	6.258488e-7	1.419336e-5	5.960700e-7
> + assert_true: expected true got false
> +FAIL X Output matches JS filter results is not true. Got false.
> assert_true: expected true got false
> +FAIL < [Test 4] 2 out of 2 assertions were failed. assert_true: expected
> true got false
>  PASS > [Test 5] Test with modulation
>  PASS   Modulation: At time 0, frequency is equal to 350.
>  PASS   Modulation: At time 0.015625, frequency is equal to 10.
> @@ -46,5 +57,5 @@
>  PASS   Modulation: Output from frequency setter equals [expected array]
> with an element-wise tolerance of
> {"absoluteThreshold":0,"relativeThreshold":0}.
>  PASS   Modulation: Output from frequency setter matches setValueAtTime
> output is true.
>  PASS < [Test 5] All assertions passed. (total 5 assertions)
> -PASS # AUDIT TASK RUNNER FINISHED: 6 tasks ran successfully.
> +FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 6 tasks were failed.
> assert_true: expected true got false

The actual and expected values are very close. This just looks like a precision issue because we're dealing with floating point values and vectorization (and different CPU architectures). I believe we'll just need to update the test to use a slightly error tolerance. In the mean time, a platform-specific baseline is the right thing to do IMO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220405/b534b5bd/attachment.htm>