[Webkit-unassigned] [Bug 238018] [JSC] Add DoNotHaveTagRegisters mode to unboxDouble

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238018

Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #455489|0                           |1
        is obsolete|                            |
 Attachment #456676|                            |review?
              Flags|                            |

--- Comment #9 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 456676

  --> https://bugs.webkit.org/attachment.cgi?id=456676&action=review

v3

Do not use a scratch register as suggested. This was not enough to get rid of the crash, it turned out the assertion in the vanilla unboxDouble call was at fault. So I'm using the WithoutAssertions call, which makes this patch 100% equivalent to the old code (literally just moving the identical lines to a common method). Not sure if the extra assertion is uncovering a bug/issue or if we were being too strict without motive, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220405/5bbd9c9a/attachment.htm>