[Webkit-unassigned] [Bug 238493] IPC::Connection::UniqueID is not possible to use in thread safe manner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 05:33:26 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=238493

--- Comment #5 from Kimmo Kinnunen <kkinnunen at apple.com> ---
> One thing that would be unsafe would be to ref the connection but I made sure the static functions that are use uniqueID don't do that.

Sending of the message *ALSO* creates a ref to the connection, so this is wrong too.

bool Connection::sendMessage(UniqueRef<Encoder>&& encoder, OptionSet<SendOption> sendOptions, std::optional<Thread::QOS> qos)
{
...
    auto sendOutgoingMessages = [protectedThis = Ref { *this }]() mutable {
        protectedThis->sendOutgoingMessages();
    };
...
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220404/c91f48da/attachment.htm>


More information about the webkit-unassigned mailing list