[Webkit-unassigned] [Bug 236746] WPEQtView is missing most features

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 01:54:20 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=236746

--- Comment #8 from Adrian Perez <aperez at igalia.com> ---
(In reply to tusooa from comment #7)
> (In reply to Adrian Perez from comment #5)
> > Comment on attachment 455583 [details]
> > Expose WebKitWebView from WPEQtView (with changelog)
> > 
> > I think we could merge this, but could you please make the style
> > bot happy? If you want to check your commit locally, you can use
> > “Tools/Scripts/check-webkit-style -g @”
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=455583&action=review
> > 
> > > Source/WebKit/ChangeLog:11
> > > +        No new tests (OOPS!).
> > 
> > You need to remove this line, or rewrite it as “No new tests needed.”
> 
> Thank you for suggesting the tool. It no longer complains with the patch I
> added just now.

Thanks, patch approved. I'll wait that the bots are green before sending
it to the commit queue :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220401/c76d32e1/attachment.htm>


More information about the webkit-unassigned mailing list