[Webkit-unassigned] [Bug 238375] Add support for element.computedStyleMap()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 1 00:47:24 PDT 2022
https://bugs.webkit.org/show_bug.cgi?id=238375
--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 456208
--> https://bugs.webkit.org/attachment.cgi?id=456208
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=456208&action=review
>> Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:67
>> +ExceptionOr<Vector<RefPtr<CSSStyleValue>>> ComputedStylePropertyMapReadOnly::getAll(const String& property) const
>
> This is mostly duplicate code. Could you factor the shared logic into a helper function?
I'm not sure how to move the common logic, because in the end they return a different value, I'm not sure it's worth using templates for this. I'll leave it as is for now, if you know a better way I'll submit a follow up patch.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220401/414c1a59/attachment.htm>
More information about the webkit-unassigned
mailing list