[Webkit-unassigned] [Bug 217655] [WPE] PlatformDisplay::shutDownEglDisplays() is never called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217655

--- Comment #5 from Claudio Saavedra <csaavedra at igalia.com> ---
(In reply to Adrian Perez from comment #2)

> 
> What was the reason to begin with to EGL display termination here instead
> of somewhere else like WebProcessMain::platformTerminate()? Also at the
> point where the atexit() handlers are invoked, surely we do not have many
> things around anymore, so for example what would happen if the
> PlatformDisplay
> implementation would needs to, let's say, spin some iterations of a RunLoop?

This is explained in a comment in PlatformDisplay:

    // EGL registers atexit handlers to cleanup its global display list.
    // Since the global PlatformDisplay instance is created before,
    // when the PlatformDisplay destructor is called, EGL has already removed the
    // display from the list, causing eglTerminate() to crash. So, here we register
    // our own atexit handler, after EGL has been initialized and after the global
    // instance has been created to ensure we call eglTerminate() before the other
    // EGL atexit handlers and the PlatformDisplay destructor.
    // See https://bugs.webkit.org/show_bug.cgi?id=157973.

I have my doubts that this is doing anything useful in practice, but tomorrow we'll know more.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210929/92cbad18/attachment.htm>