[Webkit-unassigned] [Bug 204276] Implement the 'ic' unit from CSS Values 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204276

--- Comment #32 from Kiet Ho <tho22 at apple.com> ---
Comment on attachment 439579
  --> https://bugs.webkit.org/attachment.cgi?id=439579
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439579&action=review

>> Source/WebCore/platform/graphics/Font.h:-138
>> -    FontMetrics& fontMetrics() { return m_fontMetrics; }
> 
> Are these unused?

It appears to be the case (because we also have a const getter), but if you want to be on the safe side I'll keep it.

>> LayoutTests/imported/w3c/web-platform-tests/css/css-values/ic-unit-001-expected.html:-6
>> -svg { width: 10ic; }
> 
> Are these being updated upstream too?

Yes, I'll upstream it when this patch passes CQ.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210929/8c060871/attachment.htm>