[Webkit-unassigned] [Bug 228302] macOS key-driven smooth scrolling does not stop when focus changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228302

--- Comment #14 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 439531
  --> https://bugs.webkit.org/attachment.cgi?id=439531
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439531&action=review

> Source/WebCore/page/FocusController.cpp:363
> +        if (FrameView* oldFrameView = oldFrame->view()) {

Consider `if (auto* oldFrameView = oldFrame ? oldFrame->view() : nullptr)` instead of the nested if.

> Source/WebCore/page/Page.cpp:2369
> +    for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {

Nit: "auto* frame".

> Source/WebCore/page/Page.cpp:2370
> +        FrameView* frameView = frame->view();

Nit: "auto* frameView".

> LayoutTests/fast/scrolling/unfocusing-page-while-keyboard-scrolling.html:5
> +    <script src="../../resources/js-test-pre.js"></script>

This can be `<script src="../../resources/js-test.js"></script>`.

And then the `js-test-post.js` below can be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210928/8b7b76be/attachment.htm>