[Webkit-unassigned] [Bug 204276] Implement the 'ic' unit from CSS Values 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204276

--- Comment #25 from Kiet Ho <tho22 at apple.com> ---
Comment on attachment 439128
  --> https://bugs.webkit.org/attachment.cgi?id=439128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439128&action=review

>> Source/WebCore/ChangeLog:8
>> +
> 
> Ideally there would be a description of the change here.

I'll put one in, I thought the description above and changes for each method are enough.

>> Source/WebCore/platform/graphics/FontMetrics.h:173
>> +    std::optional<float> m_ideogramWidth;
> 
> Why is this an optional? Why not have platformGlyphInit() implement the fallback behavior, rather than computeUnzoomedNonCalcLengthDouble() implement the fallback behavior?

I just feel like Font should truthfully indicate whether the ideogram width is available or not, so its users can make the correct decision. Right now computeUnzoomedNonCalcLengthDouble() falls back to 1em, but maybe in the future some other code might want to use m_ideogramWidth for something else?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210924/d4820e3e/attachment.htm>