[Webkit-unassigned] [Bug 204276] Implement the 'ic' unit from CSS Values 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 13:16:11 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=204276

--- Comment #23 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 439128
  --> https://bugs.webkit.org/attachment.cgi?id=439128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439128&action=review

> Source/WebCore/platform/graphics/FontMetrics.h:173
> +    std::optional<float> m_ideogramWidth;

Why is this an optional? Why not have platformGlyphInit() implement the fallback behavior, rather than computeUnzoomedNonCalcLengthDouble() implement the fallback behavior?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210924/2739e9e3/attachment.htm>


More information about the webkit-unassigned mailing list