[Webkit-unassigned] [Bug 230736] WebKitLegacy's module map files don't get installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230736

--- Comment #2 from Ian Anderson <iana at apple.com> ---
r271607 has too many problems and should just be reverted.

1. Its modules don't actually get installed because it doesn't make a public module map and there isn't a WebKitLegacy.h that Xcode can use to automatically generate one. If there's no public module then the private one won't get installed (and clang wouldn't use it even if it was installed).
2. It tries to make a module for WebKitLegacy on macOS, which won't work because WebKitLegacy is nested in WebKit.
3. It turns on the modules verifier which isn't supported with public Xcode and makes the project fail to build.
4. It has some unrelated changes like WebBackForwardListPrivate.h changing the @param to the wrong name.
5. It adds private umbrella headers to WebKitLegacy which aren’t necessary and have to be maintained by hand.
6. It doesn't fix all of the header errors that would make the module fail.

So I think the best thing to do is revert and start over.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210924/5ca44ea8/attachment.htm>