[Webkit-unassigned] [Bug 230331] Various tweaks in preparation for Temporal.Instant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230331

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #438998|review?                     |review+
              Flags|                            |

--- Comment #13 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 438998
  --> https://bugs.webkit.org/attachment.cgi?id=438998
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438998&action=review

r=me with comments

> Source/JavaScriptCore/runtime/TemporalDuration.cpp:122
> +        copy.append(UChar { 0x2026 }); // U+2026 ellipsis

Use `horizontalEllipsis` in <wtf/unicode/CharacterNames.h>

> Source/JavaScriptCore/runtime/TemporalObject.cpp:254
> +        throwRangeError(globalObject, scope, makeString("fractionalSecondDigits must be 'auto' or 0 through 9, not "_s, stringValue));

Also need to consider about super long string. So ellipsizeAt is necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210923/cf587d5e/attachment.htm>