[Webkit-unassigned] [Bug 230556] REGRESSION(241918 at main): [WPE][GTK] New test is timing out on bots

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 09:59:55 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230556

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #2)
> We could do this using a new ObjectIdentifier as well, which is what my
> original patches did, but then that complicates the implementation of
> WebURLSchemeHandler, which is why Youenn suggested
> std::pair<WebCore::ResourceLoaderIdentifier, WebPageProxyIdentifier>.

Well I think this will work, but it's a little weird for ::identifier to return a std::pair containing two different ObjectIdentifiers, rather than just returning one ObjectIdentifier.

Alternatively, we could give WebURLSchemeTask its own ObjectIdentifier, and WebURLSchemeHandler can use std::pair<WebURLSchemeTaskIdentifier, WebPageProxyIdentifier> just for convenience to avoid needing to add an extra HashMap.

I'll most likely implement this both ways and then decide which version I prefer. If owners have a strong preference one way or the other, please let me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210921/d1a722f8/attachment-0001.htm>


More information about the webkit-unassigned mailing list