[Webkit-unassigned] [Bug 230556] REGRESSION(241918 at main): [WPE][GTK] New test is timing out on bots

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 09:42:31 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230556

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #1)
> That's not enough, because the task identifier is not unique in the web
> process.

I keep typoing this. The task identifier (ResourceLoaderIdentifier) is not unique in the *UI* process. Alex fixed this in WebURLSchemeHandler by switching to use std::pair<WebCore::ResourceLoaderIdentifier, WebPageProxyIdentifier> to identify tasks, but I think it would be better to return that pair directly from WebURLSchemeTask::identifier. That would fix this everywhere while ensuring that the result of WebURLSchemeTask::identifier actually uniquely identifies the WebURLSchemeTask.

We could do this using a new ObjectIdentifier as well, which is what my original patches did, but then that complicates the implementation of WebURLSchemeHandler, which is why Youenn suggested std::pair<WebCore::ResourceLoaderIdentifier, WebPageProxyIdentifier>.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210921/5a734f4e/attachment.htm>


More information about the webkit-unassigned mailing list