[Webkit-unassigned] [Bug 230218] [JSC] run-javascriptcore-tests script fails on linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230218

Phillip Mates <pmates at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #438038|commit-queue-               |commit-queue+
              Flags|                            |

--- Comment #6 from Phillip Mates <pmates at igalia.com> ---
Comment on attachment 438038
  --> https://bugs.webkit.org/attachment.cgi?id=438038
fix for the bug

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 675f6cdf35a6..215167b3fb5b 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,24 @@
+2021-09-21  Phillip Mates  <pmates at igalia.com>
+
+        Fix JSC test runner warnings and errors on linux
+        https://bugs.webkit.org/show_bug.cgi?id=230218
+
+        Reviewed by Jonathan Bedard.
+
+        Fixed the following warning that arises in many scripts when they are
+        run on Linux:
+        `Can't exec "xcodebuild": No such file or directory at
+        /home/mates/igalia/WebKit/Tools/Scripts/webkitdirs.pm line 634.`
+
+        Fixed `run-javascriptcore-tests` on Linux, which was failing to invoke
+        builds before running the test suite with the error:
+        `Unrecognized option `--64-bit'`
+
+        * Scripts/webkitdirs.pm:
+        (XcodeOptions):
+        (determineIsWin64):
+        (determineIsWin64FromArchitecture): Deleted.
+
 2021-09-20  Chris Dumez  <cdumez at apple.com>

         Reduce use of makeRefPtr() and use RefPtr { } directly
diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm
index a56fe7ecb944..eb61a3ec298b 100755
--- a/Tools/Scripts/webkitdirs.pm
+++ b/Tools/Scripts/webkitdirs.pm
@@ -1008,7 +1008,9 @@ sub XcodeOptions
     determineForceOptimizationLevel();
     determineCoverageIsEnabled();
     determineLTOMode();
-    determineXcodeSDK();
+    if (isAppleCocoaWebKit()) {
+      determineXcodeSDK();
+    }

     my @options;
     push @options, "-UseSanitizedBuildSystemEnvironment=YES";
@@ -1480,14 +1482,7 @@ sub isWin64()
 sub determineIsWin64()
 {
     return if defined($isWin64);
-    $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isAnyWindows() || isJSCOnly()) && !shouldBuild32Bit());
-}
-
-sub determineIsWin64FromArchitecture($)
-{
-    my $arch = shift;
-    $isWin64 = ($arch eq "x86_64");
-    return $isWin64;
+    $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || (isAnyWindows() && !shouldBuild32Bit());
 }

 sub isCygwin()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210921/77f6c5a9/attachment.htm>