[Webkit-unassigned] [Bug 230431] RenderListMarker::imageChanged RenderBox image handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230431

--- Comment #4 from Gabriel Nava Marino <gnavamarino at apple.com> ---
(In reply to Darin Adler from comment #2)
> Comment on attachment 438528 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438528&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        No new tests (OOPS!).
> 
> Why no tests? Seems like we can and should make a test for whatever problem
> this caused.

I have added a new test to help catch this issue.

> 
> > Source/WebCore/rendering/RenderListMarker.cpp:1803
> > +    if (m_image) {
> > +        if (o == m_image->data()) {
> 
> Let’s not nest this so much:
> 
>     if (m_image && o == m_image->data()) {
>         ...

I have updated the patch to remove the unnecessary level of nesting.

Thank you for your feedback Darin!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210921/235f012e/attachment.htm>