[Webkit-unassigned] [Bug 228270] Elements cloned into an iframe cannot be accessed by webdriver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228270

--- Comment #16 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 434888
  --> https://bugs.webkit.org/attachment.cgi?id=434888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434888&action=review

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:33
> +var NodeType = {

Style: `const`?

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:34
> +    ELEMENT: 1,

Style: Is there a reason to uppercase these?  We normally CamelCase enums.

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:36
> +    DOCUMENT_FRAGMENT_NODE: 11

Style: missing trailing comma

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:37
> +  };

Style: odd indentation

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:207
> +    _isElement(value) {

Style: `{` on it's own line

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:212
> +        return ((typeof value == 'object' && value != null) ||

Style: please use `===` and `!==` unless you have a really good reason not to
Style: we prefer `"`
Style: can we split this into separate `if` or something?  Maybe use some early-returns and separate each line out so it's easier to read?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210921/ff828204/attachment-0001.htm>