[Webkit-unassigned] [Bug 230460] New: Make valgrind work properly without extra environment variables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230460

            Bug ID: 230460
           Summary: Make valgrind work properly without extra environment
                    variables
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: bmalloc
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: ggaren at apple.com

Currently to run WebKit under valgrind, we have to manually disable bmalloc with Malloc=1, or else:

 * The Gigacage breaks everything, because valgrind shadows the entire address space in resident memory, and it just can't handle that much address space
 * Even with GIGACAGE_ENABLED=0, diagnostics are worse because bmalloc does not use valgrind's annotations

Using valgrind.h, we can automatically disable bmalloc when running under valgrind to avoid needing to use the environment variable.

Additionally, WebKitGTK and WPE WebKit users also have to set the WEBKIT_FORCE_SANDBOX=0 environment variable, because the web process sandbox breaks valgrind for some reason I never attempted to understand. If we have bmalloc expose valgrind.h as a public header, then we can check for valgrind in higher layers and make this work automatically too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210919/0e9c755c/attachment.htm>