[Webkit-unassigned] [Bug 230431] RenderListMarker::imageChanged RenderBox image handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 17:10:56 PDT 2021


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com
 Attachment #438528|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 438528
  --> https://bugs.webkit.org/attachment.cgi?id=438528

View in context: https://bugs.webkit.org/attachment.cgi?id=438528&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).

Why no tests? Seems like we can and should make a test for whatever problem this caused.

> Source/WebCore/rendering/RenderListMarker.cpp:1803
> +    if (m_image) {
> +        if (o == m_image->data()) {

Let’s not nest this so much:

    if (m_image && o == m_image->data()) {

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210918/8385e106/attachment-0001.htm>

More information about the webkit-unassigned mailing list