[Webkit-unassigned] [Bug 230310] Unify the code paths for smooth scrolling, and scrolling to snap points

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 21:09:30 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230310

--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
> a lot of ScrollAnimator could move into ScrollableArea

Maybe, although it would be nice to think of snap points as a "scroll destination modifier", perhaps a ScrollableArea helper but not in the same class. We should see if there's scrolling tree code related to snap points that duplicates logic in ScrollAnimator.

> ScrollAnimatorMac
I intend to remove its m_scrollAnimationHelper and the delegate, and replace it with a ScrollAnimation subclass. After doing that, macOS just uses the m_scrollAnimation in the base class, and maybe ScrollAnimatorMac can mostly go away.

I've love to avoid both ScrollAnimator and ScrollController having platform subclasses/implementations. That's a source of a lot of brain hurt.

> ScrollAnimationKinetic
See https://bugs.webkit.org/show_bug.cgi?id=230385. I want to add a macOS specific ScrollAnimationKinetic variant that uses ScrollingMomentumCalculator. Maybe ScrollAnimationKinetic can just use BasicScrollingMomentumCalculator (or move the BasicScrollingMomentumCalculator code into ScrollAnimationKinetic).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210917/d00b11a0/attachment-0001.htm>


More information about the webkit-unassigned mailing list