[Webkit-unassigned] [Bug 230254] [GTK][a11y] Add a build option to enable ATSPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 00:29:02 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230254

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Andres Gonzalez from comment #8)
> (In reply to Carlos Garcia Campos from comment #6)
> > Created attachment 438134 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/AccessibilityObject.cpp
> +++ a/Source/WebCore/accessibility/AccessibilityObject.cpp
> @@ -3782,7 +3782,14 @@ static bool
> isAccessibilityTextSearchMatch(AXCoreObject* axObject, Accessibility
>  {
>      if (!axObject)
>          return false;
> -    return axObject->containsText(criteria.searchText);
> +
> +    // If text is empty we return true.
> +    if (criteria.searchText.isEmpty())
> +        return true;
> +
> +    return containsPlainText(axObject->title(), criteria.searchText,
> CaseInsensitive)
> +        || containsPlainText(axObject->accessibilityDescription(),
> criteria.searchText, CaseInsensitive)
> +        || containsPlainText(axObject->stringValue(), criteria.searchText,
> CaseInsensitive);
>  }
> 
> This doesn't seem related to enabling isolated tree, so perhaps you can
> submit this change as a separate patch.

Right, this is weird here, The reason of this change is because WTR uses the WebCore wrappers, and including TextIterator.h from the header pulled too many things that caused linking errors. I'll split the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210915/02fb6f88/attachment.htm>


More information about the webkit-unassigned mailing list