[Webkit-unassigned] [Bug 230241] Fix crash in 32 bits due to not enough scratch registers available

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 14:16:44 PDT 2021


--- Comment #7 from Mikhail R. Gadelha <mikhail at igalia.com> ---
The following RELEASE_ASSERT doesn't make too much sense after this patch:

    case Transition: {
        // AccessCase::createTransition() should have returned null if this wasn't true.
        RELEASE_ASSERT(GPRInfo::numberOfRegisters >= 6 || !structure()->outOfLineCapacity() || structure()->outOfLineCapacity() == newStructure()->outOfLineCapacity());

since the number of required registers depends on the arch, if we are allocating, reallocating, or doing either inline (basically the new logic in AccessCase::createTransition).

Should we keep this RELEASE_ASSERT like that? I think 6 is the bare minimum required registers but it doesn't say much.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210914/29b6290e/attachment-0001.htm>

More information about the webkit-unassigned mailing list