[Webkit-unassigned] [Bug 230241] Fix crash in 32 bits due to not enough scratch registers available

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230241

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ticaiolima at gmail.com
 Attachment #438093|review?                     |review-
              Flags|                            |

--- Comment #5 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 438093
  --> https://bugs.webkit.org/attachment.cgi?id=438093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438093&action=review

> Source/JavaScriptCore/bytecode/AccessCase.cpp:2327
> +                slowPath.append(jit.jump());

I’m not comfortable with this generating a bunch of IC code for checks and other things to always jump to slow path. This seems quite suboptimal. Isn’t there a way were we skip a case if we figure out we don’t have enough registers for it? Skipping such case will result in always taking the slow path as well, but we don’t emit any unnecessary code for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210914/8d8e8513/attachment-0001.htm>