[Webkit-unassigned] [Bug 230218] [JSC] run-javascriptcore-tests script fails on linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 07:38:36 PDT 2021


Phillip Mates <pmates at igalia.com> changed:

           What    |Removed                     |Added
           Priority|P2                          |P4

--- Comment #2 from Phillip Mates <pmates at igalia.com> ---
(In reply to Jonathan Bedard from comment #1)
> Comment on attachment 438038 [details]
> fix for the bug
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438038&action=review
> > Tools/Scripts/webkitdirs.pm:-1483
> > -    $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isAnyWindows() || isJSCOnly()) && !shouldBuild32Bit());
> I notice we're stripping the isJSCOnly() call, is that required?

I think so, given that we want the whole condition to be `false` to exclude the problematic `--64-bit` flag. In this context `!shouldBuild32Bit()` is `true` and `isAnyWindows()` is `false` so we'd need `isJSCOnly()` to be `false` to exclude the `--64-bit` flag, but it is `true`; hence I just dropped it. Dropping it might be the wrong way to resolve this, wasn't totally sure.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210913/a635dbbe/attachment-0001.htm>

More information about the webkit-unassigned mailing list