[Webkit-unassigned] [Bug 204276] Implement the 'ic' unit from CSS Values 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 12 16:57:29 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=204276

--- Comment #16 from Darin Adler <darin at apple.com> ---
(In reply to Kiet Ho from comment #14)
> 1. I think I'll need more guidance on what to do regarding
> DeprecatedCSSOMPrimitive Value

In primitiveType, add a case to the switch statement and return CSS_UNKNOWN. In getFloatValue, getStringValue, getCounterValue, getRectValue, and getRGBColorValue, do not change the code at all.

More importantly, write a test verifying the behavior of these functions. Look at the fast/css/getFloatValueForUnit.html and the tests in fast/css/getComputedStyle and fast/css/resources/CSSPrimitiveValue-exceptions.js for examples of some tests that cover what these functions do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210912/43009727/attachment.htm>


More information about the webkit-unassigned mailing list