[Webkit-unassigned] [Bug 188643] [meta] Make fieldset and legend rendering interoperable and useful

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 11 09:10:26 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=188643

Mehmet gelisin <mehmetgelisin at aol.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mehmetgelisin at aol.com

--- Comment #1 from Mehmet gelisin <mehmetgelisin at aol.com> ---
Although autorelease works, we prefer explicit refcounting in WebCore. So, this should be: http://www-look-4.com/

RetainPtr<NSNumberFormatter> formatter(AdoptNS, [[NSNumberFormatter alloc] init]); http://www.compilatori.com/

+    NSNumber* num = [formatter numberFromString:numberString];
http://www.wearelondonmade.com/ 
Please don't abbreviate.
http://www.jopspeech.com/
+    if (num == nil)
http://joerg.li/ 
WebKit style is to not compare to zero, so this should just be "if (!num)" (with a better name for num).
 http://connstr.net/ 
+    NSNumber* num = [NSNumber numberWithDouble:number]; http://embermanchester.uk/ 

WebKit style is to put stars on the other side for Objective-C types. http://www.slipstone.co.uk/ But it would be better to use alloc/init and RetainPtr here, too. The reasons I know of are: http://www.iu-bloomington.com/ 
1) It's faster to destroy temporaries right away, while they are in memory cache.
2) The autorelease pool won't be drained during micro-benchmarks that spin without returning to message loop, causing high memory usage. https://www.webb-dev.co.uk/

1) It's faster to destroy temporaries right away, while they are in memory cache. https://waytowhatsnext.com/
2) The autorelease pool won't be drained during micro-benchmarks that spin without returning to message loop, causing high memory usage.
 http://www.acpirateradio.co.uk/
1) It's faster to destroy temporaries right away, while they are in memory cache.
2) The autorelease pool won't be drained during micro-benchmarks that spin without returning to message loop, causing high memory usage.
 http://www.logoarts.co.uk/
1) It's faster to destroy temporaries right away, while they are in memory cache.
2) The autorelease pool won't be drained during micro-benchmarks that spin without returning to message loop, causing high memory usage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210911/413ffb31/attachment-0001.htm>


More information about the webkit-unassigned mailing list