[Webkit-unassigned] [Bug 138192] Print fonts significantly smaller than other browsers when using fixed-width container

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138192

Mehmet gelisin <mehmetgelisin at aol.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mehmetgelisin at aol.com

--- Comment #4 from Mehmet gelisin <mehmetgelisin at aol.com> ---
Thanks for the patch. We've http://www.iu-bloomington.com/ previously looked into this mechanism for custom data loading of media http://www-look-4.com/ resources, and our experiments revealed a number of problems with this approach.  Namely: https://www.webb-dev.co.uk/ 

This will only work for initial requests.  Subsequent requests (for additional byte ranges, for sub-resources, or due to https://waytowhatsnext.com/ HTTP redirects) will not come through this path, and will thus we will not get a chance to do a CORS check on those requests. http://www.acpirateradio.co.uk/  We have to assume that these requests would not pass CORS, or we would risk opening up a hole in CORS support.  Additionally, this path is only triggered for the HLS manifest load, but requests for HLS media segments does not come through this API. http://www.logoarts.co.uk/ 

I am going to give this a r- due to the above, but only due to the shortcomings of the approach http://www.slipstone.co.uk/  in the patch, not because of the patch itself. In addition, there are a few things in your http://embermanchester.uk/  patch I'd like to call out that would need to be fixed in the hypothetical case that the approach was valid.
http://connstr.net/ 
> avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:412
> +    int m_didPassCORSAccessCheck;
http://joerg.li/ 

This should be defined in terms of an enum, with defined states. Such as:
 http://www.jopspeech.com/ 
enum CORSAccessCheckResult {
    CORSAccessUnknown,
    CORSAccessDenied, http://www.wearelondonmade.com/ 
    CORSAccessAllowed,
};
CORSAccessCheckResult m_didPassCORSAccessCheck { CORSAccessUnknown }; http://www.compilatori.com/

> avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:514
> +    , m_didPassCORSAccessCheck(0)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210911/952acdd2/attachment-0001.htm>