[Webkit-unassigned] [Bug 229556] AX: Make PDFs loaded via <embed> accessible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229556

--- Comment #14 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 437808
  --> https://bugs.webkit.org/attachment.cgi?id=437808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437808&action=review

> Source/WebCore/ChangeLog:16
> +        This patch only implements `<embed>` PDF support for Mac â iOS support will

some unicode character here Mac â iOS su

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3833
> +        if (isPluginMatchingCriteria(backingObject, criteria)) {

in this case I feel like it won't return the right data. the search should enumerate all results (like below with findMatchingObject) and then return the count.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3846
> +        if (isPluginMatchingCriteria(backingObject, criteria)) {

ditto with this. I think for the searching what we need to do is during the findMatchingObjects, including plugins. then here, after we get the results, we need to enumerate them and see if the renderWidgetChildren, and their sub-children and down the tree, match any results, then insert them into the final array

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210909/500ba3a9/attachment-0001.htm>