[Webkit-unassigned] [Bug 230100] New: Fix ASan+UBSan builds: part two

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230100

            Bug ID: 230100
           Summary: Fix ASan+UBSan builds: part two
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
        Depends on: 229122

Fix ASan+UBSan builds: part two.

In Bug 229122 Comment #9, Alexey Proskuryakov writes:
> This is not what I was asking about. I was asking about including
> sanitizer.xcconfig twice. This happens because it's included by both
> asan.xcconfig and ubsan.xcconfig. There is a good chance that some settings
> are messed up (at least duplicated) because of this.

So it turns out that including sanitizer.xcconfig is basically okay (no duplicated settings), but investigating this lead me to discover something else:

Xcode variables defined in an xcconfig file that is specified on the command-line are not resolved until later, so two variables with the same name will overwrite each other (last one wins), even if they use '$(inherited)'.

This meant that, for example, defining WK_SANITIZER_OTHER_CFLAGS_YES in both sanitizer.xcconfig and ubsan.xcconfig will not work as expected--only one variable will win (the one in ubsan.xcconfig).

So this bug is to fix those issues and clean up the xcconfig files in Tools/sanitizer.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=229122
[Bug 229122] Fix ASan+UBSan builds with Xcode 13
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210909/ffba96a2/attachment.htm>