[Webkit-unassigned] [Bug 229556] AX: Make PDFs loaded via <embed> accessible

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 8 10:03:23 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=229556

--- Comment #9 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #6)
> Created attachment 437632 [details]
> Patch

--- a/Source/WebCore/plugins/PluginViewBase.h
+++ a/Source/WebCore/plugins/PluginViewBase.h

--- a/Source/WebCore/plugins/PluginViewBase.h
+++ a/Source/WebCore/plugins/PluginViewBase.h

+    virtual NSObject *accessibilityHitTest(const IntPoint&) const { return 0; }
+    virtual NSObject *accessibilityObject() const { return nullptr; }

In both of these you want to return nil. Do we need the return value to be NSObject *? I think in most cases where we return a platform AX object, the return type is id.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210908/8637333b/attachment.htm>


More information about the webkit-unassigned mailing list