[Webkit-unassigned] [Bug 229961] New: Gracefully handle security bugs in apply-watchlist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229961

            Bug ID: 229961
           Summary: Gracefully handle security bugs in apply-watchlist
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com

Currently security bugs fails in apply-watchlist ews with a misleading exception which doesn't really indicate the reason for failure. e.g.: https://ews-build.webkit.org/#/builders/21/builds/52652/steps/9/logs/stdio

  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 53, in run
    bug = self._tool.bugs.fetch_bug(bug_id)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 493, in fetch_bug
    return Bug(self.fetch_bug_dictionary(bug_id), self)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 486, in fetch_bug_dictionary
    return self._parse_bug_dictionary_from_xml(self._fetch_bug_page(bug_id))
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 462, in _parse_bug_dictionary_from_xml
    bug["title"] = self._string_contents(soup.find("short_desc"))
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 402, in _string_contents
    return unicode(soup.string)
AttributeError: 'NoneType' object has no attribute 'string'


The real reason is that the bots which run the webkitpy command to apply watchlist do not have access to security bugs. We should gracefully handle this case and improve the error message to clearly indicate what's happening.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210906/996b37ef/attachment-0001.htm>