[Webkit-unassigned] [Bug 225850] [PATCH] fix webkitgtk build on macOS
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 6 05:02:04 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=225850
Michael Catanzaro <mcatanzaro at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mcatanzaro at gnome.org
Attachment #437405|review?, commit-queue? |review+, commit-queue-
Flags| |
--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 437405
--> https://bugs.webkit.org/attachment.cgi?id=437405
Combined patch
View in context: https://bugs.webkit.org/attachment.cgi?id=437405&action=review
It's probably been a long time since somebody got WebKitGTK to build on macOS. Impressive!
Your changes all look fine to me. I'm just going to leave nits about the line spacing.
> Source/WebKit/ChangeLog:8
> + implementations to allow compiling webkitgtk on macOS.
> + https://bugs.webkit.org/show_bug.cgi?id=225850
There should be one blank line in the ChangeLog above the URL.
> Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:50
> +#endif
> // Although it's available on Darwin, SOCK_SEQPACKET seems to work differently
Leave a blank line here, please.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210906/45d41457/attachment.htm>
More information about the webkit-unassigned
mailing list