[Webkit-unassigned] [Bug 214448] Web Share permission policy "web-share" and "self" as the allowlist

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 14:45:29 PDT 2021


--- Comment #5 from Marcos Caceres <marcos at marcosc.com> ---
(In reply to Devin Rousso from comment #4)
> Comment on attachment 437154 [details]
> Patch
> > Source/WebCore/page/Navigator.cpp:148
> > +    auto* frame = this->frame();
> > +    if (!isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::WebShare, *frame->document(), LogFeaturePolicyFailure::Yes)) {
> Why not just use the `document` argument?

oops, yeah... copy/pasta from the other patch.  

> Also, EWS appears to be crashing in this function.

Question: canShare() does this check:

    auto* frame = this->frame();
    if (!frame || !frame->page())
        return false;

As a followup, I wonder if we should do the same check in .share() and reject with something? The spec doesn't currently to cover this (or maybe this should change to be a "fully active" check?).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210902/461055ed/attachment-0001.htm>

More information about the webkit-unassigned mailing list